Skip to content

Modifications on HashMap and HashSet #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tur11ng wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Modifications on HashMap and HashSet #44

tur11ng wants to merge 8 commits into from

Conversation

@tur11ng
Copy link

@tur11ng tur11ng commented Jul 2, 2023

  • Changed the inner representation of entries in HashMap
  • Added the Keys() and Values() methods to both HashMap and HashSet data structures
  • Did benchmarks on the results and compared my fork with yours. This repository was used with custom modifications. Found that they did not differ in time and I think my implementation extends the interface making it a bit more useful.

Thanks you for your time.

@zyedidia
Copy link
Owner

zyedidia commented Jul 4, 2023

What's the reason for changing the inner representation of entries? I think the addition of the Keys and Values methods is fine, but I'm not sure the other changes are necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tur11ng @zyedidia